Migrate rustc_mir_dataflow to diagnostic structs #100744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rustbot
added
A-translation
rust-highfive
added
the
S-waiting-on-review
|
@rustbot blocked |
rustbot
added
S-blocked
|
r? diagnostics |
ghost
force-pushed
the
migrate-rustc-mir-dataflow
branch
from
acf080c to
ee2b161
Compare
|
@rustbot review |
rustbot
added
S-waiting-on-review
ghost
marked this pull request as ready for review
|
cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki |
ghost
changed the title
JohnTitor
reviewed
Aug 23, 2022
compiler/rustc_error_messages/locales/en-US/rustc_mir_dataflow.ftl
Outdated
Show resolved
Hide resolved
davidtwco
requested changes
Aug 23, 2022
davidtwco
approved these changes
Aug 23, 2022
|
@bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
klensy
reviewed
Aug 26, 2022
| rustc_macros = { path = "../rustc_macros" } | ||
| rustc_middle = { path = "../rustc_middle" } | ||
| rustc_serialize = { path = "../rustc_serialize" } | ||
| rustc_session = { path = "../rustc_session" } |
There was a problem hiding this comment.
Don't see where rustc_session used :-(
Probably SessionDiagnostic.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 27, 2022
…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#100724 (Migrate ast lowering to session diagnostic) - rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`) - rust-lang#100738 (Diagnostics migr const eval) - rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs) - rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`) - rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword) - rust-lang#100836 (Migrate `rustc_attr` crate diagnostics) - rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic) - rust-lang#100900 (on `region_errors.rs`) Failed merges: - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.